fix(ui5-select): align value state message header with design spec#13766
Merged
Conversation
NakataCode
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
NakataCode
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
|
🚀 Deployed on https://pr-13766--ui5-webcomponents-preview.netlify.app |
kgogov
approved these changes
Jul 6, 2026
kgogov
left a comment
kgogov
left a comment
Contributor
There was a problem hiding this comment.
The box-shadow: none reset is necessary — ValueStateMessage.css sets per-state colored inset shadows via CSS custom properties that were leaking into the Select's [ui5-popover] context unintentionally. The reset correctly cancels them before applying sapContent_HeaderShadow. Verified in browser across all four value states. LGTM.
NakataCode
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
|
🧹 Preview deployment cleaned up: https://pr-13766--ui5-webcomponents.netlify.app |
|
🎉 This PR is included in version v2.24.0 🎉 The release is available on v2.24.0 Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The value state message header in the Select dropdown had a colored inset box-shadow acting as a
bottom border (e.g. red for error, orange for warning). This did not match the Horizon
Visual Design specification.
Changes in
SelectPopover.css:error,warning,success,information) scoped to.ui5-select-popoversapContent_HeaderShadowto the value state message header to visually separate it from theoptions list below.
JIRA: BGSOFUIPIRIN-7061
Related to: #13308